Bso wildy slayer #5877
Merged
Bso wildy slayer #5877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing activities quest and picking a quest, currently it just shows all the quests and it's hard to keep track of what's completed and what isn't. Following the #bso-vote poll, this hides the quests you have completed from the list and only shows ones you haven't completed. Then when every quest is completed it shows (completed) at the end instead of providing an empty list.
…o bso-wildy-slayer
…o bso-wildy-slayer
…t into TastyPumPum-bso-wildy-slayer
…o bso-wildy-slayer
…schoolbot into bso-wildy-slayer
|
@ellipsis-dev review |
This comment was marked as spam.
This comment was marked as spam.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@ellipsis-dev review |
|
OK! Reviewing this PR... Responding to this comment by @TastyPumPum. For more information about Ellipsis, check the documentation. |
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 85423fb in 2 minutes and 45 seconds
More details
- Looked at
4558lines of code in68files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/lib/MUser.ts:901
- Draft comment:
Ensure thorough testing for thebuildTertiaryItemChangesmethod, especially with the new wilderness and task conditions. This method now handles multiple scenarios (wilderness, on task, both, or neither), and each condition could significantly affect gameplay. Consider adding unit tests to cover all these scenarios to ensure that item drop chances are modified correctly under each condition. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_mPCb4AafDrli8E3m
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes:
Other checks:
Summary:
This PR introduces wilderness slayer tasks, updates related item handling and boosts, modifies commands for new features, and adjusts testing configurations.
Key points:
Generated with ❤️ by ellipsis.dev